On Mon, 9 May 2022 12:38:48 GMT, Raffaello Giulietti <d...@openjdk.java.net> wrote:
>> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about >> multi-line (block) comments. Nothing in the code proper has changed, except >> for the addition of redundant but clarifying parentheses in some expressions. >> >> >> Greetings >> Raffaello > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 4511638: Double.toString(double) sometimes produces incorrect results Generally looks solid! src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 882: > 880: try { > 881: FloatToDecimal.appendTo(f, this); > 882: } catch (IOException ignored) { What is the motivation for wrapping with IOException? src/java.base/share/classes/java/lang/Double.java line 33: > 31: import java.util.Optional; > 32: > 33: import jdk.internal.math.FloatingDecimal; Presumably the FloatingDecimal import here and in Float can be removed. src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 38: > 36: * This class exposes a method to render a {@code double} as a string. > 37: * > 38: * @author Raffaello Giulietti New code shouldn't use author tags. ------------- PR: https://git.openjdk.java.net/jdk/pull/3402
