On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev <almat...@openjdk.org> 

> - It is not possible to support native JDK commands such as "java" inside Mac 
> App Store bundles due to embedded info.plist. Workarounds suggested in 
> JDK-8286122 does not seems to be visible.
>  - With proposed fix we will enforce "--strip-native-commands" option for 
> jlink, so native JDK commands are not included when generating Mac App Store 
> bundles.
>  - Custom runtime provided via --runtime-image should not contain native 
> commands as well, otherwise jpackage will throw error.
>  - Added two tests to validate fix.

test/jdk/tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java line 48:

> 46: 
> 47:     @Test
> 48:     public static void test() throws Exception {

I'd give some more descriptive names to test functions than `test` and `test2`. 
Something like `testWithStripNativeCommands` and 
`testWithoutStripNativeCommands` maybe?


PR: https://git.openjdk.java.net/jdk/pull/8666

Reply via email to