On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev <almat...@openjdk.org> wrote:

> - No changes to code provided by original fix.
>  - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute 
> unsigned code and code should be at least ad hoc signed.
>  - Signing of app bundle produced by AppContentTest.java fails, since it has 
> invalid app bundle structure with added files into Content folder. Thus test 
> is executed but failure is always expected on macOS aarch64.

test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 72:

> 70:     @Parameters
> 71:     public static List<Object[]> data() {
> 72:         return List.of(new Object[][] {{"true"}, {"false"}});

I'd replace use of `@Parameters` with `@Parameter` as follows:

@Test
@Parameter("true")
@Parameter("false")
public static void test(boolean doSign) {...}

-------------

PR: https://git.openjdk.java.net/jdk/pull/8527

Reply via email to