On Thu, 12 May 2022 13:32:03 GMT, xpbob <d...@openjdk.java.net> wrote:

>> set memory.swappiness to 0,swap space will not be used 
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>> 
>> 
>>     Memory Limit: 50.00M
>>     Memory Soft Limit: Unlimited
>>     Memory & Swap Limit: 100.00M
>>     Maximum Processes Limit: 4194305 
>> 
>> =>
>> 
>>     Memory Limit: 50.00M
>>     Memory Soft Limit: Unlimited
>>     Memory & Swap Limit: 50.00M
>>     Maximum Processes Limit: 4194305
>
> xpbob has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   add test

LGTM. Consider a better name for the test :)

test/hotspot/jtreg/containers/docker/TestMemoryWithCgroupV1.java line 90:

> 88:     }
> 89: 
> 90:     private static void testOperatingSystemMXBeanAwareness(String 
> memoryAllocation, String swapAllocation,

Please use a more telling name for this. Perhaps this? 
`testOSBeanSwappinessMemory`.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8285

Reply via email to