On Thu, 10 Mar 2022 08:52:17 GMT, Сергей Цыпанов <d...@openjdk.java.net> wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with >> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when >> called with vararg of size 0, 1, 2. >> >> In general replacement of `Arrays.asList()` with `List.of()` is dubious as >> the latter is null-hostile, however in some cases we are sure that arguments >> are non-null. Into this PR I've included the following cases (in addition to >> those where the argument is proved to be non-null at compile-time): >> - `MethodHandles.longestParameterList()` never returns null >> - parameter types are never null >> - interfaces used for proxy construction and returned from >> `Class.getInterfaces()` are never null >> - exceptions types of method signature are never null > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8282662: Revert dubious changes in MethodType src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 727: > 725: MethodVisitor mv = cw.visitMethod(accessFlags, > 726: method.getName(), desc, null, > 727: typeNames(List.of(exceptionTypes))); Since `exceptionTypes` is an array, it might be better to keep using `Arrays.asList`, or add an overload for `typeNames` that works on class arrays. ------------- PR: https://git.openjdk.java.net/jdk/pull/7729
