On Fri, 13 May 2022 18:29:56 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Ichiroh Takiguchi has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8285517: System.getenv() returns unexpected value if environment variable 
>> has non ASCII character
>
> src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 251:
> 
>> 249: 
>> 250:     /**
>> 251:      * Return the {@code sun.jnu.encoding} system property.
> 
> This can be eliminated by changing the`@return` block tag below to `{@return 
> the {@code sun.jnu.encoding} ...}`.

Hello @naotoj .
I appreciate your comment.
I'd like to confirm one thing.
I applied following change

    /**
     * {@return the {@code sun.jnu.encoding} system property}
     *
     * <strong>{@link SecurityManager#checkPropertyAccess} is NOT checked
     * in this method. The caller of this method should take care to ensure
     * that the returned property is not made accessible to untrusted 
code.</strong>
     */


By javadoc command with -html5 option, above part was converted to

Returns the sun.jnu.encoding system property. 
SecurityManager.checkPropertyAccess(java.lang.String) 
is NOT checked in this method. The caller of this method should take care to 
ensure that the returned 
property is not made accessible to untrusted code.

The 1st word changed from **Return** to **Returns**.
Is it OK ?
And it seems `@return` is translated to Japanese on Japanese environment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8378

Reply via email to