On Mon, 16 May 2022 21:54:52 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provider description
>
> test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 48:
>
>> 46: */
>> 47: public class SchemaTest {
>> 48: private static final String XSD_8144117 = "<?xml version='1.0'?>\n" +
>
> If it is not from the upstream Xerces test but our own, can we utilize text
> blocks here?
Our source level is still generally 8. The expectation is also that this patch
will be backported.
> test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java line 79:
>
>> 77:
>> 78: /*
>> 79: * DataProvider: valid xsd
>
> This comment is the same as the above provider. Can we change it to a more
> meaningful one?
Updated with a bit more description.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8732
