On Sun, 22 May 2022 05:58:25 GMT, Christian Stein <cst...@openjdk.org> wrote:

> Commit 
> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640
>  for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) 
> added an optional description accessor on the `ToolProvider` interface. It 
> included a typo in` jlink`'s description resource key lookup: 
> `"jlink.desciption"`
> 
> This follow-up commit fixes the typo by adding the missing `r` character: 
> `"jlink.description"`.
> 
> This commit also also adds an automated check that ensures all current and 
> future tool provider implementations within the JDK don't throw an exception 
> when invoking their name and description accessor methods. Specific tool 
> names and descriptions are not expected by this general test.

test/jdk/java/util/spi/ToolProviderDescriptionTest.java line 46:

> 44: 
> 45:     static List<String> listToolDescriptions() {
> 46:         return 
> StreamSupport.stream(ServiceLoader.load(ToolProvider.class).spliterator(), 
> false)

it doesn't matter for this test but SL does have a stream method that could be 
used instead:

ServiceLoader.load(ToolProvider.class)
     .stream()
    .map(ServiceLoader.Provider::get)
    .sorted(Comparator.comparing(ToolProvider::name))
    ...

-------------

PR: https://git.openjdk.java.net/jdk/pull/8825

Reply via email to