On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
> Hi, > > May I have this test update reviewed? > > The ForceGC could be enhanced by using smaller wait/sleep time, and shared > cleaner. > > Thanks, > Xuelei LGTM - but it may be good to have an other reviewer (@mlchung ?) test/lib/jdk/test/lib/util/ForceGC.java line 50: > 48: for (int i = 0; i < 100; i++) { > 49: System.gc(); > 50: System.out.println("doIt() iter: " + iter + ", gc " + i); Maybe the trace should be printed only if `(i % 10 == 0) && (iter % 100 == 0)` to avoid having too many traces in the log? ------------- Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8907