On Fri, 3 Jun 2022 15:06:48 GMT, Jorn Vernee <[email protected]> wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 5269:
>
>> 5267: }
>> 5268:
>> 5269: static MethodHandle dropArguments(MethodHandle target, int pos,
>> Class<?>[] valueTypes, boolean trusted) {
>
> Having a boolean that flips the behaviour makes it harder to know what that
> `true` or `false` literal at the call site does. I'd suggest splitting this
> into `dropArgumentsTrusted`, which doesn't clone the array, and
> `dropArguments` which always makes a copy (and the latter calls former). WDYT?
Yeah, that sounds better.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8923
