On Tue, 7 Jun 2022 02:22:53 GMT, Xiaohong Gong <xg...@openjdk.org> wrote:
>> test/micro/org/openjdk/bench/jdk/incubator/vector/LoadMaskedIOOBEBenchmark.java
>> line 97:
>>
>>> 95: public void byteLoadArrayMaskIOOBE() {
>>> 96: for (int i = 0; i < inSize; i += bspecies.length()) {
>>> 97: VectorMask<Byte> mask = VectorMask.fromArray(bspecies, m,
>>> i);
>>
>> For other case "if (offset >= 0 && offset <= (a.length - species.length()))
>> )" we are anyways intrinsifying, should we limit this micro to work only for
>> newly optimized case.
>
> Yeah, thanks and it's really a good suggestion to limit this benchmark only
> for the IOOBE cases. I locally modified the tests to make sure only the IOOBE
> case happens and the results show good as well. But do you think it's better
> to keep as it is since we can also see the performance of the common cases to
> make sure no regressions happen? As the current benchmarks can also show the
> performance gain by this PR.
It was just to remove the noise from a targeted micro benchmark. But we can
keep it as it is.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8035
