On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner <[email protected]>
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix test message
test/jdk/tools/jar/modularJar/Basic.java line 1050:
> 1048: */
> 1049: @Test(dataProvider = "resolutionNames")
> 1050: public void
> updateFooModuleResolutionDoNotResolveByDefaultAndWarnIfResolved(String
> resolutionName, Predicate<ModuleResolution> hasWarning) throws IOException {
Update the existing tests is good but overly long lines make it too hard to
read (it will make future side-by-side view impossible). Can you trim all these
lines down to something closer to the existing tests in this file?
-------------
PR: https://git.openjdk.java.net/jdk/pull/9049