On Tue, 31 May 2022 17:23:18 GMT, Rémi Forax <fo...@openjdk.org> wrote:
>> For completeness, I think including SUPER is reasonable, even though has >> been a no-op for some time. (Some time in the future, there could be a class >> file version aware additions to this enum class.) Well spotted omission. > > `ACC_SUPER`may be reconed as `ACC_IDENTITY`by Valhalla, so i'm not sure it's > a good idea to add ACC_SUPER. As discussed elsewhere in the PR, given the historical existence of ACC_SUPER, I think it is reasonable to leave it all. Also, even if removed later in the release, it would be helpful to validate how overlapping flags can be handled in practice in Valhalla. ------------- PR: https://git.openjdk.org/jdk/pull/7445
