> Please review a small patch for dumping the failure reason when the MSVCRT > libraries or the Java Virtual Machine fails to load on Windows, which can > provide invaluable insight when debugging related launcher issues.
Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'openjdk:master' into patch-4 - Back out change to DLL_ERROR4 for separate RFE - Missing spacing between errors - Introduce warning when system error cannot be determined - LoadLibrary checks should explicitly use NULL - Dump error (if any) when libraries fail to load - Prettify DLL_ERROR4 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9749/files - new: https://git.openjdk.org/jdk/pull/9749/files/990ee4fd..284ac2f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9749&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9749&range=03-04 Stats: 164674 lines in 2718 files changed: 78252 ins; 68762 del; 17660 mod Patch: https://git.openjdk.org/jdk/pull/9749.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9749/head:pull/9749 PR: https://git.openjdk.org/jdk/pull/9749
