On Wed, 16 Nov 2022 15:41:06 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 273:
>
>> 271:
>> 272: /**
>> 273: * Combine one or more {@link StringTemplate StringTemplates} to
>> produce a combined {@link StringTemplate}.
>
> Suggestion:
>
> * Combine one or more {@link StringTemplate StringTemplates} into a
> single {@link StringTemplate}.
Should we say more about what the properties of the returned template are? E.g.
that the fragments are concatenated (in which order?) and values are also
concatenated.
> src/java.base/share/classes/java/lang/template/ValidatingProcessor.java line
> 41:
>
>> 39: * This interface describes the methods provided by a generalized string
>> template processor. The
>> 40: * primary method {@link ValidatingProcessor#process(StringTemplate)} is
>> used to validate
>> 41: * and compose a result using a {@link StringTemplate StringTemplate's}
>> fragments and values lists.
>
> `compose` as in `produce` ?
This use of the word `compose` occurs in other places. While I'm not opposed to
it, it has not to do with function composition in mathematical sense (unlike
StringTemplate::compose), so I'd stay clear.
> src/java.base/share/classes/java/util/FormatProcessor.java line 42:
>
>> 40: * the embedded expression that follows immediately after the
>> 41: * <a href="../util/Formatter.html#syntax">format specifier</a>.
>> 42: * StringTemplate expressions without a preceeding specifier, use "%s" by
>
> Suggestion:
>
> * StringTemplate expressions without a preceding specifier, use "%s" by
And, `StringTemplate` is missing a surrounding code/link tag
-------------
PR: https://git.openjdk.org/jdk/pull/10889
