On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unused variable
src/hotspot/cpu/aarch64/aarch64.ad line 3635:
> 3633: }
> 3634: } else if (_method->intrinsic_id() ==
> vmIntrinsicID::_ensureMaterializedForStackWalk) {
> 3635: __ nop();
Please add a comment explaining why the nop is needed or desirable here.
src/hotspot/cpu/x86/x86_64.ad line 2174:
> 2172: RELOC_DISP32);
> 2173: } else if (_method->intrinsic_id() ==
> vmIntrinsicID::_ensureMaterializedForStackWalk) {
> 2174: __ addr_nop_5();
Needs a comment. I guess this is because of how call sizes are computed.
-------------
PR: https://git.openjdk.org/jdk/pull/10952
