On Mon, 9 Jan 2023 23:13:29 GMT, Claes Redestad <redes...@openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Explicitly lea external address
>
> Explicitly loading the address to a register seems to do the trick, avoiding 
> the pitfalls of `as_Address(AddressLiteral)` - which apparently only works 
> (portably) when we know for certain the address is in some allowed range. 
> There's no measurable difference on microbenchmarks (there might be a couple 
> of extra lea instructions on the vectorized paths, but that disappears in the 
> noise). Thanks @fisk for the suggestion!

Thanks @cl4es for fixing this issue. Changes look good to me.

-------------

PR: https://git.openjdk.org/jdk/pull/10847

Reply via email to