On Fri, 3 Feb 2023 02:02:39 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
> Modify the `Space` instances used for size comparison to be created with
> total number of bytes derived from the Windows `diskFree` utility instead of
> Cygwin’s `df`.
test/jdk/java/io/File/GetXSpace.java line 152:
> 150: }
> 151:
> 152: private static String getCallerTotalSpace(String name) throws
> IOException {
It seems a bit fragile to be parsing the output of `fsutil volume diskFree` as
the output seems to vary by Windows releases and maybe configuration. So
minimally, I think it should be changed to use ProcessTools so that the command
and the output show up in the .jtr file.
In passing, you might want to choose a different method name to make it clearer
what it does, maybe volumeDiskFree?
-------------
PR: https://git.openjdk.org/jdk/pull/12397
