The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
----------------------------------------------------------------------
On Fri, 3 Mar 2023 20:17:24 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tighten up reporting of string template errors (fewer messages)
>
> src/java.base/share/classes/java/lang/template/ProcessorLinkage.java line 37:
>
>> 35:
>> 36: /**
>> 37: * Policies using this additional interface have the flexibility to
>> specialize
>
> Since it is 'sealed' it may clarify the use to say "Builtin policies"...
Changing
> src/java.base/share/classes/java/lang/template/StringProcessor.java line 58:
>
>> 56: /**
>> 57: * Constructs a {@link String} based on the template fragments and
>> values in the
>> 58: * supplied {@link StringTemplate} object.
>
> Some inconsistency in the use of link/linkplain and the capitalization of
> stringTemplate, the instance or the type.
> (As compared to TemplateProcessor.process(stringTemplate))
> Suggestion:
>
> * supplied {@link StringTemplate} object.
Changing
> src/java.base/share/classes/java/util/FormatProcessor.java line 42:
>
>> 40: * {@link Formatter} specifications and values found in the {@link
>> StringTemplate}.
>> 41: * Unlike {@link Formatter}, {@link FormatProcessor} uses the value from
>> the
>> 42: * embedded expression that immediately follows, no whitespace, after the
>
> Suggestion:
>
> * embedded expression that immediately follows, without whitespace, the
Changing
> src/java.base/share/classes/java/util/FormatProcessor.java line 80:
>
>> 78: * int x = 10;
>> 79: * int y = 20;
>> 80: * String result = thaiFMT."%d\{x} + %d\{y} = %d\{x + y}";
>
> The inclusion of format specifiers that yield the same results as the default
> (%s) may mislead developers into thinking they need the format specifier.
> Making the examples look more complicated than necessary.
> Can the examples, show customized output.
>
> Suggestion:
>
> * String result = thaiFMT."%d{x} + %d{y} = %d{x + y}";
Changing
-------------
PR: https://git.openjdk.org/jdk/pull/10889
