On Wed, 1 Mar 2023 06:27:19 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java
>> line 68:
>>
>>> 66: public abstract class CallArranger {
>>> 67: // Linux PPC64 Little Endian uses ABI v2.
>>> 68: private static final boolean useABIv2 = ByteOrder.nativeOrder() ==
>>> ByteOrder.LITTLE_ENDIAN;
>>
>> Now that I'm here. This could be a potentially interesting case for having 2
>> subclasses of CallArranger: one for `useABIv2 == true` and one for `false`.
>
> Yeah, let's wait until we know what changes we need for AIX (and Big Endian
> linux).
I think having a ABIV1CallArranger (for Big Endian linux and AIX) and a
ABIV2CallArranger (linux ppc64le) will make sense. That's why I have removed
the LinuxPPC64CallArranger.java with
https://github.com/openjdk/jdk/pull/12708/commits/fb87284c1d3df946db378d196d7f48cd3acbab01.
I guess a good time for such cleanup will be after the code for all variants
is available (not part of this PR).
-------------
PR: https://git.openjdk.org/jdk/pull/12708
