Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v6]

[Alan Bateman]

On Fri, 10 Mar 2023 21:34:56 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> Runtime.exec and ProcessBuilder.start methods create a new operating system 
>> process with the program and arguments. Many applications configure a 
>> logging subsystem to monitor application events. Logging a process start 
>> message with the program, arguments, and stack trace can identify the caller 
>> and purpose.
>> Logging the process start event is complementary to the process start event 
>> generated for JFR (Java Flight Recorder).
>
> Roger Riggs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Reword @implNote to indicate logging can be enabled. (But is not by default)

Marked as reviewed by alanb (Reviewer).

src/java.base/share/classes/java/lang/ProcessBuilder.java line 194:

> 192: {
> 193:     // Lazily and racy initialize when needed, racy is ok, any logger is 
> ok
> 194:     private static System.Logger LOGGER ;

Minor nit, there's a space before the semi-colon.

src/java.base/share/classes/java/lang/ProcessBuilder.java line 205:

> 203:         System.Logger logger = 
> System.getLogger("java.lang.ProcessBuilder");
> 204:         return logger.isLoggable(System.Logger.Level.DEBUG) ? logger : 
> null;
> 205:     }

Is initLogger left over from a previous iteration?

-------------

PR: https://git.openjdk.org/jdk/pull/12862