On Thu, 23 Mar 2023 15:51:48 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 81: >> >>> 79: */ >>> 80: AIX, >>> 81: ; >> >> While browsing another PR I noticed that jlink also has an [OperatingSystem >> enum](https://github.com/openjdk/jdk/blob/master/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java#L34), >> which has an additional `UNKNOWN` enum constant. Would it make sense to >> have an `UNKNOWN` constant here too, which could also make it possible to >> use this enum directly with jlink too? > > Its not needed here. In the jlink version, that value is only used if the > mapping from os.name fails. > With the new OperatingSystem enum, it is exactly one of the os's supported by > the build. If there is no build support then it never gets to a runtime error. Isn't the convention to have enum values uppercase? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1146490982
