On Thu, 23 Mar 2023 22:34:24 GMT, Hannes Greule <d...@openjdk.org> wrote:
>> After merging master into https://github.com/openjdk/jdk/pull/9862, we >> encountered test failures (e.g., >> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541). >> The Classfile API tries to read from constant pool index 0 if a >> MethodParameters attribute has an entry without name. >> >> The fix is simply using `readUtf8EntryOrNull` instead of `readUtf8Entry`. >> The related code already correctly handles nullability. >> >> I didn't find an appropriate test class so I added a new one. Let me know if >> there's a better place or if the test can be improved somehow. >> >> As I don't have a JBS account, someone needs to create a bug report there >> for me. Thanks. > > Hannes Greule has updated the pull request incrementally with one additional > commit since the last revision: > > Apply suggestions from code review > > Co-authored-by: liach <7806504+li...@users.noreply.github.com> test/jdk/jdk/classfile/BoundAttributeTest.java line 46: > 44: /* > 45: * @test > 46: * @issue 8304837 Should be `@bug`, not `@issue`. Did you run this test? Did it not complain at `@issue`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13167#discussion_r1146952634
