On Mon, 27 Mar 2023 13:17:35 GMT, Chen Liang <li...@openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   SplitConstantPool performance improvement
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>  line 256:
> 
>> 254: 
>> 255:     private Frame getFrame(int offset) {
>> 256:         for (var f : frames) {
> 
> How large is the frames list expected to be? We can probably perform binary 
> searches if the list is too large.

The number of frames is usually low, however I'll try to benchmark the 
difference.
Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10991#discussion_r1149395671

Reply via email to