On Thu, 4 May 2023 16:19:04 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> Classfile API didn't handle transformations of class files version 50 and >> below correctly. >> >> Proposed fix have two parts: >> 1. Inflation of branch targets does not depend on StackMapTable attribute >> presence for class file version 50 and below. Alternative fallback >> implementation is provided. >> 2. StackMapTable attribute is not generated for class file versions below 50. >> >> StackMapsTest is also extended to test this patch. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > Apply suggestions from code review > > Thanks for review. > > Co-authored-by: liach <7806504+li...@users.noreply.github.com> Since we want an option to toggle stackmap generation, will you add it to the Classfile options as a temporary measure, before we keep track of these options in a stateful object (with hierarchy resolver etc.) like brian envisioned? ------------- PR Comment: https://git.openjdk.org/jdk/pull/13478#issuecomment-1535631393
