On Wed, 24 May 2023 16:26:28 GMT, Alan Bateman <[email protected]> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review suggestions
>
> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 140:
>
>> 138: */
>> 139: /* package-private */
>> 140: static String toUpperCase(String str) {
>
> A bit icky to have OperatingSystem to expose a static method to convert
> Strings as it's nothing to do with OperatingSystem, is there anywhere else?
Delaying the initialization of OperatingSystem made it possible to revert to
String.toUpperCase().
Enabled by the fix in PR [14181](https://github.com/openjdk/jdk/pull/14181).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14063#discussion_r1207228241
