On Fri, 23 Jun 2023 14:30:49 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> To minimise the number of changes, we can go for using `jint` in >> `AwtMenu::GetItem`. >> >> What do you thing, @djelinski and @TheShermanTanker? > > Hmm, I lean towards jint as I feel it conveys the fact that it is a Java > parameter clearer, intuitively to me it makes sense that a Java integer type > would still work in a C++ for loop in native code You're right… it gives a hint it'll be an upcall into Java. Let's go for `jint` then. I don't think there's a need to change the type of the for-loop variable to `jint`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1240041248
