On Fri, 28 Jul 2023 15:44:54 GMT, Alan Bateman <al...@openjdk.org> wrote:
> This is a test only change to a test that exercises core reflection from > virtual threads. One of the tests (testNewInstance6) uses a custom scheduler > in setup to check that calling a constructor reflectively, where the > constructor parks, doesn't pin the underlying carrier. The test schedules an > unpark from a virtual thread but the test is missing a call to Thread::join, > thus creating a race between shutdown of the scheduler and the unpark. Two > sightings of the test failing so far, both -Xcomp and ZGC. > > While in the area, two usages of Thread.sleep in the test have been replaced > with latches. The change looks good to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15073#pullrequestreview-1554107159
