Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

[Amit Kumar]

On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 <d...@openjdk.org> wrote:

>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   Address suggestions from Jorn Vernee

src/hotspot/cpu/s390/frame_s390.cpp line 228:

> 226: 
> 227: bool frame::upcall_stub_frame_is_first() const {
> 228:   assert(is_upcall_stub_frame(), "must be optimzed entry frame");

typo: s/optimzed/optimized

src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger.java
 line 70:

> 68:     private static final ABIDescriptor CLinux = abiFor(
> 69:             new VMStorage[] { r2, r3, r4, r5, r6, }, // GP input
> 70:             new VMStorage[] { f0, f2, f4, f6 }, // FP intput

typo: s/intput/input

src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger.java
 line 205:

> 203:     }
> 204: 
> 205:     // Compute recipe for transfering arguments / return values to C 
> from Java.

typo: s/transfering/transferring

src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger.java
 line 257:

> 255:     }
> 256: 
> 257:     // Compute recipe for transfering arguments / return values from C 
> to Java.

typo: s/transfering/transferring

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1262149143
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1262152073
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1262153723
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1262154919