On Fri, 8 Sep 2023 15:41:41 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Notice there is patch https://github.com/openjdk/jdk/pull/14655 (bug >> 8310901) for converting these usages to a new `newStringLatin1NoRepl`. > > Going from `jla.newStringNoRepl(bytes, ISO_...)` to > `jla.newStringLatin1NoRepl(bytes)` isn't much of a code simplification, so > this distracts a bit from the bulk of the changes in this PR. I agree that it > *might* help inlining since the former calls into a large method, but I think > we ought to focus on one thing at a time so if this doesn't significantly > help on the benchmarks we have available it would be better to leave it out > for now. I'll have a look at #14655 though I note that @RogerRiggs has already commented that this might not carry its own weight. These internal API bridges are a nuisance so we need to take care to make sure that any addition is actually necessary, not just convenient for the time being. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15555#discussion_r1320037600
