On Thu, 17 Aug 2023 09:23:30 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

>>> These benchmarks are all small arrays. We need to check for possible 
>>> regressions here. 
>> 
>> Sorry, all large arrays. I suspect that the average-length sort is not 
>> represented.
>> 
>>> Also, I'm rather concerned that we might lose the data from this PR.
>> 
>> How does keep alive work? Will the data from that external web site still be 
>> here for the reader in 15 years' time?
>
>> How does keep alive work? Will the data from that external web site still be 
>> here for the reader in 15 years' time?
> 
> Hm... I thought that at least full webrevs are stored somewhere on 
> https://cr.openjdk.org/. Turns out they aren't. They are stored on 
> https://openjdk.github.io/cr/.
> 
> Okay, a cheap thing to do *now* is to ask the Web Archive to store it, which 
> I just did:
> 
>   * 
> https://web.archive.org/web/20230817091712/https://openjdk.github.io/cr/?repo=jdk&pr=13568&range=06
>   * 
> https://web.archive.org/web/20230817091943/https://github.com/openjdk/jdk/compare/0f51e6326373ff7d4a4d9a0e3a2788401f73405d...f7f7e11adf9984ee1ce316e3e36f5e351b49bb97.diff
>   * 
> https://web.archive.org/web/20230817092146/https://github.com/openjdk/jdk/pull/13568

> @pavelrappo Pavel Rappo

Vladimir, please do not consider me a reviewer. I'm merely a passer-by: I 
didn't review a single line of this PR, nor do I have expertise to do so.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13568#issuecomment-1720983110

Reply via email to