On Mon, 18 Sep 2023 14:41:14 GMT, Chen Liang <li...@openjdk.org> wrote:
>> A few classes in `sun.util` package have non-final fields which could easily
>> be marked `final`.
>
> src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line
> 71:
>
>> 69: private final class PropertiesFileDecoder extends CharsetDecoder {
>> 70:
>> 71: private final CharsetDecoder cdUTF_8 =
>> UTF_8.INSTANCE.newDecoder()
>
> Can be static as well.
I'm not sure. Why do you think so? CharsetDecoder is not thread-safe.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15736#discussion_r1335644148
