On Sun, 24 Sep 2023 02:46:38 GMT, 温绍锦 <d...@openjdk.org> wrote:
>> 1. Reduce duplicate stringSize code >> 2. Move java.lang.StringLatin1.getChars to >> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other >> packages also need to use this method > > 温绍锦 has updated the pull request incrementally with one additional commit > since the last revision: > > restore StringUTF16.getChars(int,int,int,byte[]) and > StringUTF16.getChars(long,int,int,byte[]) You could benefit from compiling and testing in your repo before committing; it would cut down on the spurious changes. and/or (before pushing) squash the intermediate commits to a single commit with a salient comment. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15699#issuecomment-1733814668
