On Wed, 11 Oct 2023 15:43:19 GMT, Aggelos Biboudis <abimpou...@openjdk.org> wrote:
>> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html > > Aggelos Biboudis has updated the pull request incrementally with one > additional commit since the last revision: > > Fix duplicate method name and add a new test in > PrimitivePatternsSwitchErrors src/java.base/share/classes/java/lang/runtime/ExactConversionsSupport.java line 45: > 43: private ExactConversionsSupport() { } > 44: > 45: /** Exactness method from int to byte nit: there seems to be an indentation issue in these javadoc, the subsequent lines should be aligned with the first one. What I see in other javadocs is that we don't write in the first line after the `/**` and instead the javadoc starts in the subsequent line. side: would it make sense to generate this file mechanically? seems like a great candidate for that ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1357212078
