On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey <[email protected]> wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update code comments
test/jdk/java/util/zip/ZipFile/ZipSourceCache.java line 80:
> 78: HashMap internalMap;
> 79: int numSources;
> 80: try (ZipFile zipFile = new ZipFile(ZIPFILE_NAME)) {
Do you think changing this to:
new ZipFile(relativeFile)
would be better and more clear about the intent? A few lines below, we use `new
ZipFile(absoluteFile)` which I think is good because it makes it clear what is
being done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1368547393
