On Mon, 23 Oct 2023 20:07:07 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo. > > src/java.base/share/classes/java/math/BigInteger.java line 137: > >> 135: * results indicate a multiply algorithm for numbers using this >> 136: * category of representation must run in <em>at least</em> >> 137: * <i>O</i>(<i>n</i> log <i>n</i>). Common multiply > > "Common _multiply_" or "Common _multiplication_"? Doing some grammar research ... In English, using a noun as an adjective is called an "attributive noun," so the "multiplication" in "multiplication algorithm" would play that role. Strictly speaking to "adjective-ifly" a verb would be to use a participle, one way to do that anyway -- "multiplying algorithm." In any case, "multiply algorithm" reads okay to me, but I don't mind changing it to "multiplication algorithm." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16298#discussion_r1369237797
