On Fri, 6 Oct 2023 22:15:00 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` > CLI options to jpackage to provide signing identity directly to `codesign` > and `productbuild` tools as per CSR > [JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631). > - If `codesign` or `productbuild` fails, then output of these tools will be > printed to stdout to help user diagnose issues with signing using new > options. Examples with sign identity set to "test" which does not exist on > system: >> Error: "codesign" failed with following output: >> test: no identity found > >> Error: "productbuild" failed with following output: >> productbuild: error: Cannot write product to "/Users/SOMEDIR/Test-1.0.pkg". >> (Could not find appropriate signing identity for “test”.) > - Added error handling not to allow invalid combinations of signing options. > - Updated signing tests to test new changes. This pull request has now been integrated. Changeset: f1dfdc1a Author: Alexander Matveev <almat...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/f1dfdc1a79f3a16eae58d15d1945541a08f7e145 Stats: 555 lines in 24 files changed: 450 ins; 24 del; 81 mod 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild Reviewed-by: asemenyuk ------------- PR: https://git.openjdk.org/jdk/pull/16085
