On Wed, 8 Nov 2023 19:02:36 GMT, Mark Sheppard <[email protected]> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> converted list to array.
>
> test/lib/jdk/test/lib/process/ProcessTools.java line 387:
>
>> 385: */
>> 386:
>> 387: private static String[] addTestThreadFactoryArgs(String
>> testThreadFactoryName, String[] command) {
>
> would it be appropriate, at this juncture, to rename the method parameter
> "command" here, and throughout the associated code, to commandArgs, as the
> actual command i.e. java is added in createJavaProcessBuilder, and the
> parameter references the java command's args? or is that too much hassle.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16442#discussion_r1387085932
