On Sun, 8 Oct 2023 17:01:37 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> @liach , thank you for working on this fix. I've given the changes an >> initial skim, but will need to do a more thorough review before approving or >> offering suggestions for changes. My top priority for the next few weeks >> will be JDK 21 CSRs so it may take a while for me to circle back to this PR. > >> @jddarcy Joe, can you take a look at this patch where annotation handling on >> parameters now uses available `MethodParameters` attribute to match from >> explicit formal parameter indices to implicit formal parameter indices? > > @liach sorry for the delays. > > I'll be attending to some other matters in the immediate future; please ping > me again in a few weeks if I don't reply first. > Hello Joe @jddarcy, is there anything that I need to do to move this patch > forward? Should I file a CSR for the behavior change to > `getAnnotatedParameterTypes()` and `getParameters()[i].getAnnotatedType()` > due to this bugfix, as it now annotates correctly? Hi @liach , sorry for the continued delays. I'm currently working through reviewing a backlog of CSRs for JDK 22. This is (still) on my list to get to. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13664#issuecomment-1805182300
