On Thu, 30 Nov 2023 08:00:12 GMT, Damon Fenacci <dfena...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use byte off branches in char_array_compress >> Verified by manual tests with "-XX:AVX3Threshold=0" >> And test in the PR >> test/hotspot/jtreg/compiler/intrinsics/string/TestStringConstructionIntrinsics.java > > src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8547: > >> 8545: // bail out when there is nothing to be done >> 8546: testl(tmp5, 0xFFFFFFFF); >> 8547: jcc(Assembler::zero, post_alignment); > > @RogerRiggs I think you changed the wrong line 😉 > Suggestion: > > jccb(Assembler::zero, post_alignment); Thanks for spotting that mistake, corrected in [b2fc385](https://github.com/openjdk/jdk/pull/16425/commits/b2fc38550ba95bcd7ec1ae4f52f22b220afcb045). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16425#discussion_r1410870186
