On Fri, 1 Dec 2023 09:48:23 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review for this change to the test library's > `OutputAnalyzer` class, which proposes to remove some unnecessary logging > from the `getExitValue()` call? > > As noted in https://bugs.openjdk.org/browse/JDK-8321163, right now this > method logs: > > > [2023-11-24T11:47:54.557561Z] Waiting for completion for process 24909 > [2023-11-24T11:47:54.557873Z] Waiting for completion finished for process > 24909 > > > even when the process has already completed and the exit value already known. > The change in this PR makes it such that if the exit value is available then > we no longer log this (nor call `process.waitFor()`). > > No new tests have been added given the nature of this change. tier1, tier2 > and tier3 tests continue to pass with this change. This pull request has now been integrated. Changeset: 672f3732 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/672f37324f9f15ae3e03b9b3b86c7106e6a09eed Stats: 7 lines in 1 file changed: 4 ins; 0 del; 3 mod 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed Reviewed-by: stefank, lmesnik ------------- PR: https://git.openjdk.org/jdk/pull/16919
