On Tue, 2 Jan 2024 07:05:22 GMT, Jaikiran Pai <[email protected]> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into JDK-8320360-bounds
>>
>> # Conflicts:
>> # test/jdk/jdk/classfile/LimitsTest.java
>> - added bug # to the test
>> - 8320360: ClassFile.parse: Some defect class files cause unexpected
>> exceptions to be thrown
>
> src/java.base/share/classes/jdk/internal/classfile/impl/ClassReaderImpl.java
> line 283:
>
>> 281: public void copyBytesTo(BufWriter buf, int p, int len) {
>> 282: try {
>> 283: buf.writeBytes(buffer, p, len);
>
> `java.lang.classfile.BufWriter` doesn't specify any `@throws` for its
> `writeXXX` methods. Should it be specified (of course in a separate PR)?
That is a good point, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16762#discussion_r1439414618
