On Tue, 16 Jan 2024 15:16:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Glavo has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains six additional commits since >> the last revision: >> >> - Merge branch 'openjdk:master' into zip-utils >> - Merge branch 'openjdk:master' into zip-utils >> - Merge branch 'openjdk:master' into zip-utils >> - Merge branch 'openjdk:master' into zip-utils >> - Merge branch 'openjdk:master' into zip-utils >> - use ByteArrayLittleEndian in ZipUtils > > Hello Glavo, I see that you are interested in pursuing this change further. > Would you mind getting the latest micro benchmark numbers which this proposed > change? I see that your PR description has a run from some time back, getting > a latest one would be useful. > > Additionally, I see that https://github.com/openjdk/jdk/pull/14636 where you > had proposed a test case for the `ByteArrayLittleEndian` class (in addition > to other things) got closed without being integrated. Would you mind adding a > new test case for that class as part of this current PR since you have a few > more new methods being added to that class? @jaikiran Can you review this PR again? ------------- PR Comment: https://git.openjdk.org/jdk/pull/14632#issuecomment-1895683407
