On Mon, 27 Nov 2023 22:33:16 GMT, Hans Boehm <d...@openjdk.org> wrote:
>> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/Reference.java line 546: > >> 544: * <a href="package-summary.html#reachability"><em>strongly >> reachable</em></a>, >> 545: * regardless of any other actions of the program that might >> otherwise cause >> 546: * the object to become unreachable; thus, the object is not > > Delete "regardless of any other actions of the program that might otherwise > cause the object to become unreachable" ? I have no idea what actions would > qualify there. And it's more misleading thann informative, since IMO the real > concern here is compiler dead variable elimination. The only action I can think of would be nulling out the last strong reference to the object in question. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1472074132
