On Mon, 19 Feb 2024 16:57:23 GMT, Aleksei Efimov <aefi...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Typo
>> - Merge branch 'master' into JDK-8325579
>> - Rename test and refine comment
>> - Enhance test
>> - JDK-8325579
>
> src/java.naming/share/classes/module-info.java line 51:
>
>> 49: * network times out.
>> 50: * <br> If a custom socket factory is provided via property
>> 51: * {@code java.naming.ldap.factory.socket} and unconnected
>> sockets
>
> Suggestion:
>
> * <br> If a custom socket factory is provided via {@code
> java.naming.ldap.factory.socket} environment
> * property and unconnected sockets
Addressed.
> src/java.naming/share/classes/module-info.java line 51:
>
>> 49: * network times out.
>> 50: * <br> If a custom socket factory is provided via property
>> 51: * {@code java.naming.ldap.factory.socket} and unconnected
>> sockets
>
> Since we're referencing socket factory env property, maybe we can also
> document it here. Something like:
>
> <li>{@code java.naming.ldap.factory.socket}:
> <br>The value of this environment property specifies the fully
> qualified class name of the socket factory used by the LDAP provider.
> This class must implement the javax.net.SocketFactory abstract class.
> By default the environment property is not set.
> </li>
Added.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1495580384
PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1495580620
