On Fri, 8 Mar 2024 17:29:09 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the Locale.US code comment >> >> Signed-off-by: sendaoYan <yansendao....@alibaba-inc.com> > > test/jdk/java/util/Properties/PropertiesStoreTest.java line 59: > >> 57: private static final String DATE_FORMAT_PATTERN = "EEE MMM dd >> HH:mm:ss zzz uuuu"; >> 58: // use a neutral locale, since when the date comment was written by >> Properties.store(...), >> 59: // it internally calls the Date.toString() which always writes in a >> locale insensitive manner > > Instead of blindly removing the comment, I'd suggest reflecting the fact that > `Date.toString()` uses `Locale.US` for time zone names. Thanks for your advice. The comment has been updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18155#discussion_r1518571662
