On Tue, 27 Feb 2024 15:10:37 GMT, Nizar Benalla <d...@openjdk.org> wrote:
> # Issue > - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were > made to the method signatures but this modification isn't reflected in the @ > since tags. The @ since tags need to be updated. > > I changed the @\since tags to better accurately show when the methods were > introduced. We would like to have an automated way to check `@since` tags, for that, the existing mistakes should be cleaned. It is true there were some mistakes in FFM (and there are some mistakes even in production code elsewhere), but those that persist in the mainline should be cleaned as well. I think I'd also add that `java.lang.classfile.ClassFile.JAVA_23_VERSION` should also have `@since 23`. Regarding that is the definition of "a new method" - I would say one reasonable way to detect new methods is based on JVM descriptors. There are some methods in the JDK that have been retrofitted from non-generic to generic in a binary compatible way, and it seems unfounded to require `@since` for that. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18030#issuecomment-1969180172
