On Mon, 8 Apr 2024 19:45:14 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test change
>
> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
> line 36:
>
>> 34: String libraryName = "awt";
>> 35: File awtSharedObjectPath = new File("/test/lib/libawt.so");
>> 36: File awtArchivePath = new File("/test/lib/libawt.a");
>
> How does this work? Did you create a "/test" directory? I don't have it on my
> machine.
I am not 100% sure. I think it is a temporary directory under jtreg. I referred
to the other test under loadLibrary. @mlchung Could you clarify this ?
> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
> line 37:
>
>> 35: File awtSharedObjectPath = new File("/test/lib/libawt.so");
>> 36: File awtArchivePath = new File("/test/lib/libawt.a");
>> 37: awtSharedObjectPath.renameTo(awtArchivePath);
>
> This should work for this test. But, what if an AWT test gets executed after
> your test? I think copy is safer than renaming.
Maybe i need to rename it back. If we just copy, it would take the .so itself,
so we cant enforce it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1557366150
PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1557365063
