On Wed, 17 Apr 2024 08:51:39 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Reflecting code formatting suggestion. >> - First lookup the main method, and only then the constructor. >> - Attempting to solve JDK-8329581 by only ignoring j.l.NoSuchMethodError > > src/java.base/share/native/libjli/java.c line 477: > >> 475: // and don't continue with the next variant; >> 476: // leave any exception pending, so that it is visible to the >> caller: >> 477: return 1; > > Hello Jan, the comment says "don't continue", yet this returns `1` which > represents "continue". Should this return `0` instead? Uh, you are right of course. Thanks for noticing! Fixed. (I believe the difference here is not currently observable, as this is the last step in the cascade, but may become observable if the order changes.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18753#discussion_r1568511740
