On Mon, 22 Apr 2024 13:46:59 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Simplify tests >> - Add a test for null arg >> - Add a test for findOrThrow() >> - Merge branch 'master' into symbol-lookup-findorthrow >> - Change exception type >> - Update src/java.base/share/classes/java/lang/foreign/package-info.java >> >> Co-authored-by: Jorn Vernee <jornver...@users.noreply.github.com> >> - Update src/java.base/share/classes/java/lang/foreign/SymbolLookup.java >> >> Co-authored-by: Maurizio Cimadamore >> <54672762+mcimadam...@users.noreply.github.com> >> - Update src/java.base/share/classes/java/lang/foreign/SymbolLookup.java >> >> Co-authored-by: Maurizio Cimadamore >> <54672762+mcimadam...@users.noreply.github.com> >> - Fix typo >> - Update after PR comments >> - ... and 2 more: https://git.openjdk.org/jdk/compare/099a64e8...0e06e0d6 > > test/jdk/java/foreign/loaderLookup/TestSymbolLookupFindOrThrow.java line 41: > >> 39: >> 40: static { >> 41: System.loadLibrary("Foo"); > > Where is this lib defined? it is defined in the sub-folder `lookup` in the file `libFoo.c`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18474#discussion_r1577755855
